Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Round arithmetic is using standard Math functions #447

Closed
karmacoma opened this issue Feb 23, 2017 · 2 comments
Closed

Round arithmetic is using standard Math functions #447

karmacoma opened this issue Feb 23, 2017 · 2 comments
Assignees
Milestone

Comments

@karmacoma
Copy link
Contributor

For reliable number accuracy and consistency with the rest of application, all math operations such as floor, ceil, addition, subtraction should be conducted using the bignum.js: https://github.com/LiskHQ/lisk/blob/development/helpers/bignum.js.

Affected modules:

@karmacoma
Copy link
Contributor Author

@MaciejBaj: Please start with unit tests against existing round logic. Adding failing context for potential number accuracy problem. Then make code changes. Thanks.

@karmacoma
Copy link
Contributor Author

@MaciejBaj: Once we've proven through unit tests, it might require rebuilding of memory tables. This we also need check.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants