Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add network identifier in block signature #4932

Closed
shuse2 opened this issue Mar 9, 2020 · 0 comments · Fixed by #5057
Closed

Add network identifier in block signature #4932

shuse2 opened this issue Mar 9, 2020 · 0 comments · Fixed by #5057
Assignees
Milestone

Comments

@shuse2
Copy link
Collaborator

shuse2 commented Mar 9, 2020

Description

Network identifier should be used while signing the block with the same logic as transactions.
However, this information should not be stored anywhere.

Motivation

In order to prevent replay of block, network identifier need to be added.

Acceptance Criteria

  • Test if signature includes network identifier
  • Test if network identifier is not included, signature is invalid

Related issues

#4915

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants