This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Improvements for Auth module #7832
Comments
16 tasks
shuse2
pushed a commit
that referenced
this issue
Dec 8, 2022
### What was the problem? This PR resolves #7832 ### How was it solved? Functionality: - Refactored `AuthModule.beforeCommandExecute()` to always use only 1 get and 1 set store operation, instead of up to 2 gets and 2 sets. - `RegisterMultisignatureCommand.verify()`: Moved sorting of optional keys after checking that mandatory keys are sorted Tests: - Renamed `framework/test/unit/modules/auth/method.ts` to `method.spec.ts` - Renamed `framework/test/unit/modules/auth/auth_module.ts` into `module.ts` - Unskiped _Multi-signature registration transaction_ from `module.spec.ts` - `beforeCommandExecute` test _initialize senderAccount with default values_ now uses correct value for `numberOfSignatures` and asserts all properties of the account - endpoint test suite `verifyTransaction` renamed to `isValidSignature` ### How was it tested? All unit tests passed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Functionality:
AuthModule.beforeCommandExecute()to always use only 1 get and 1 set store operation, instead of up to 2 gets and 2 sets.RegisterMultisignatureCommand.verify(): Move sorting of optional keys after checking that mandatory keys are sortedTests:
framework/test/unit/modules/auth/method.tstomethod.spec.tsframework/test/unit/modules/auth/auth_module.tsintomodule.tsmodule.spec.tsbeforeCommandExecutetest initialize senderAccount with default values should use correct value fornumberOfSignaturesand asert all properties of the accountverifyTransactionactually testsisValidSignatureand should be renamedThe text was updated successfully, but these errors were encountered: