Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Inconsistent error handling in command verify functions of NFT module #8986

Closed
Tracked by #7245
Incede opened this issue Sep 14, 2023 · 0 comments
Closed
Tracked by #7245

Inconsistent error handling in command verify functions of NFT module #8986

Incede opened this issue Sep 14, 2023 · 0 comments
Assignees
Milestone

Comments

@Incede
Copy link
Contributor

Incede commented Sep 14, 2023

Description

The NFT module throws an exception on errors, while the token module returns a VerificationResult with a VerifyStatus of TransactionVerifyResult.INVALID. In both cases, the state machine handles the errors similarly only altering the debug log that is created. However, the error handling for all command’s verify functions should be consistent.

Acceptance Criteria

  • Update error handling in command verify functions of NFT module to return with appropriate status instead of throwing
  • Update relevant unit tests

Additional Information

release/6.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants