This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Standarize eslint - Closes #3749 #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| const path = require('path'); | |||
There was a problem hiding this comment.
Why do you extract path if it's only used on the branch for new relic?
There was a problem hiding this comment.
no global import..
I think path won't hurt to be required in the root
pablitovicente
approved these changes
Aug 2, 2019
diego-G
suggested changes
Aug 2, 2019
…sk-sdk into 3749-standarize_eslint
diego-G
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Remember to open an issue for this comment ;) #4033 (comment)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
framework had several eslint rules that is not consistent with other packages
How did I solve it?
Remove most of the custom rules.
Changed to
warnlevel for the rules that has many usageHow to manually test it?
Test should pass (only changed the rule)
Review checklist