This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Extract http api from modules - Closes #455 #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move all linkage with http protocol from modules into api/http. closes LiskArchive#455
karmacoma
changed the title
karmacoma
changed the title
4miners
reviewed
Mar 10, 2017
helpers/httpApi.js
Outdated
| sanitize: function (property, schema, cb) { | ||
| return function (req, res, next) { | ||
| req.sanitize(req[property], schema, function (err, report, sanitized) { | ||
| if (err) { |
4miners
reviewed
Mar 10, 2017
modules/accounts.js
Outdated
| open: function (req, cb) { | ||
| library.schema.validate(req.body, schema.open, function (err) { | ||
| if (err) { | ||
| return setImmediate(cb, err[0].message); |
There was a problem hiding this comment.
Are you sure that err[0] always exists?
4miners
approved these changes
Mar 10, 2017
karmacoma
approved these changes
Mar 10, 2017
karmacoma
added
ready
and removed
type: bug
chore
type: docs
type: improvement
type: refactoring
type: test
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all linkage with http protocol from modules into api/http.
Closes #455