Update token module initGenesisState hook - Closes #7119 #7145
Conversation
shuse2
force-pushed
the
7119-update_token_genesis
branch
from
1fd0ad7
to
a44e786
Compare
shuse2
force-pushed
the
7119-update_token_genesis
branch
from
a44e786
to
3d3dd02
Compare
|
|
||
| // import { getRandomBytes } from '@liskhq/lisk-cryptography'; | ||
|
|
||
| const oneLisk = BigInt('100000000'); |
There was a problem hiding this comment.
maybe oneLiskToBeddows is more accurate?
There was a problem hiding this comment.
I think oneLSKToBeddows is more accurate, since Lisk a brand and LSK is the token's name. It's also aligned with our functions like convertLSKToBeddows and we can use this function here like const oneLSKToBeddows = convertLSKToBeddows('1');, I think this is more readable.
There was a problem hiding this comment.
I think we could use convertLSKToBeddows but LSK or beddow is not the main point here, so ill just update the variable name
|
|
||
| // import { getRandomBytes } from '@liskhq/lisk-cryptography'; | ||
|
|
||
| const oneLisk = BigInt('100000000'); |
There was a problem hiding this comment.
I think oneLSKToBeddows is more accurate, since Lisk a brand and LSK is the token's name. It's also aligned with our functions like convertLSKToBeddows and we can use this function here like const oneLSKToBeddows = convertLSKToBeddows('1');, I think this is more readable.
…-update_token_genesis
What was the problem?
This PR resolves #7119
How was it solved?
initGenesisStatehook according to the LIPHow was it tested?