Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update dryRunTransaction response to return errorMessage #7817

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

ishantiw
Copy link
Contributor

What was the problem?

This PR resolves #7808

How was it solved?

  • Add errorMessage to the response
  • Rename success->result

How was it tested?

Run a node and then create a transaction and call txpool_dryRunTransaction RPC to see the result

@ishantiw ishantiw requested a review from shuse2 November 23, 2022 13:59
@ishantiw ishantiw self-assigned this Nov 23, 2022
framework/src/abi/abi.ts Outdated Show resolved Hide resolved
framework/src/engine/endpoint/txpool.ts Show resolved Hide resolved
Copy link
Contributor

@mosmartin mosmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

- Add errorMessage to the response
- Rename success->result
@ishantiw ishantiw merged commit 19773d5 into development Nov 24, 2022
@ishantiw ishantiw deleted the 7808-update-dryrun-response branch November 24, 2022 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dryRunTransaction response to have error
3 participants