Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Updates unit tests; ValidatorsMethod #9126

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Conversation

has5aan
Copy link
Contributor

@has5aan has5aan commented Oct 30, 2023

What was the problem?

This PR resolves issue #8115 & issue #7267 Some points in the issue, potentially requiring no change are responded to in a comment on the issue.

How was it solved?

Adds and updates tests for ValidatorsMethod.

How was it tested?

All tests are passing.

@has5aan has5aan self-assigned this Oct 30, 2023
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #9126 (a616525) into release/6.1.0 (223afce) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head a616525 differs from pull request most recent head 1429ec6. Consider uploading reports for the commit 1429ec6 to get more accurate results

Impacted file tree graph

@@                Coverage Diff                @@
##           release/6.1.0    #9126      +/-   ##
=================================================
+ Coverage          84.35%   84.39%   +0.04%     
=================================================
  Files                652      652              
  Lines              23970    23964       -6     
  Branches            3490     3488       -2     
=================================================
+ Hits               20219    20224       +5     
+ Misses              3751     3740      -11     
Files Coverage Δ
framework/src/modules/validators/method.ts 97.84% <ø> (+7.77%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@AndreasKendziorra AndreasKendziorra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left an additional comment in issue #8115

framework/test/unit/modules/validators/method.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/validators/method.spec.ts Outdated Show resolved Hide resolved
framework/test/unit/modules/validators/method.spec.ts Outdated Show resolved Hide resolved
has5aan and others added 2 commits October 30, 2023 14:05
…eenTimestamps.

Co-authored-by: AndreasKendziorra <40799768+AndreasKendziorra@users.noreply.github.com>
@shuse2 shuse2 enabled auto-merge (squash) November 1, 2023 13:01
@shuse2 shuse2 merged commit cf9caad into release/6.1.0 Nov 1, 2023
9 checks passed
@shuse2 shuse2 deleted the 8115-validators-test branch November 1, 2023 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants