Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference implementation links #503

Merged
merged 9 commits into from Dec 15, 2023
Merged

Add reference implementation links #503

merged 9 commits into from Dec 15, 2023

Conversation

sitetester
Copy link
Contributor

@sitetester sitetester commented Nov 13, 2023 •
edited

@sitetester sitetester self-assigned this Nov 13, 2023
ishantiw
ishantiw requested changes Nov 14, 2023
View reviewed changes
proposals/lip-0044.md Outdated Show resolved Hide resolved
proposals/lip-0045.md Outdated Show resolved Hide resolved
@sitetester sitetester marked this pull request as ready for review November 15, 2023 08:49
@janhack janhack requested review from sergeyshemyakov and removed request for janhack November 30, 2023 15:40
sergeyshemyakov
sergeyshemyakov requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@sergeyshemyakov sergeyshemyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for taking a lead with the reference links!
I have made suggestions on how to make the links more precise and accurate. Please have a look.

proposals/lip-0037.md Outdated Show resolved Hide resolved
proposals/lip-0039.md Outdated Show resolved Hide resolved
proposals/lip-0049.md Outdated Show resolved Hide resolved
proposals/lip-0050.md Outdated Show resolved Hide resolved
proposals/lip-0051.md Outdated Show resolved Hide resolved
proposals/lip-0068.md Outdated Show resolved Hide resolved
proposals/lip-0067.md Outdated Show resolved Hide resolved
proposals/lip-0069.md Outdated Show resolved Hide resolved
proposals/lip-0070.md Outdated Show resolved Hide resolved
proposals/lip-0071.md Outdated Show resolved Hide resolved
sergeyshemyakov
sergeyshemyakov requested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@sergeyshemyakov sergeyshemyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added one small comment. Note that there are my comments from the previous review that are not addressed.

proposals/lip-0067.md Outdated Show resolved Hide resolved
sergeyshemyakov
sergeyshemyakov approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@sergeyshemyakov sergeyshemyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

ishantiw
ishantiw requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the links can point to more accurate issue/epic for implementation

proposals/lip-0041.md Outdated Show resolved Hide resolved
proposals/lip-0059.md Outdated Show resolved Hide resolved
proposals/lip-0064.md Outdated Show resolved Hide resolved
proposals/lip-0066.md Outdated Show resolved Hide resolved
proposals/lip-0067.md Outdated Show resolved Hide resolved
proposals/lip-0070.md Outdated Show resolved Hide resolved
ishantiw
ishantiw approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@ishantiw ishantiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 🙌

janhack
janhack approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@janhack janhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial approval

@janhack janhack merged commit 0dcdf7e into main Dec 15, 2023
@janhack janhack deleted the 421-link-to-reference-implementation branch December 15, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@janhack janhack janhack approved these changes

@sergeyshemyakov sergeyshemyakov sergeyshemyakov approved these changes

Assignees

@sitetester sitetester

Labels
lip modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sitetester @ishantiw @janhack @sergeyshemyakov @karmacoma