Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LIP: "Introduce Auth module" #92

Merged
merged 13 commits into from Sep 7, 2021
Merged

Add LIP: "Introduce Auth module" #92

merged 13 commits into from Sep 7, 2021

Conversation

ricott1
Copy link
Contributor

@ricott1 ricott1 commented Aug 11, 2021

No description provided.

@ricott1 ricott1 self-assigned this Aug 11, 2021
IkerAlus
IkerAlus suggested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 bad link, the rest LGTM.

Also, my suggestion is to move all the links at the end of the source file as done in previous LIPs.

proposals/lip-introduce_the_auth_module.md Outdated Show resolved Hide resolved
@ricott1 ricott1 requested a review from IkerAlus August 11, 2021 12:51
IkerAlus
IkerAlus reviewed Aug 12, 2021
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment regarding the entries creation needs clarification before approval.

proposals/lip-introduce_the_auth_module.md Outdated Show resolved Hide resolved
IkerAlus
IkerAlus suggested changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding the nonce check.

proposals/lip-introduce_the_auth_module.md Outdated Show resolved Hide resolved
@ricott1 ricott1 requested a review from IkerAlus August 13, 2021 08:00
IkerAlus
IkerAlus approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MaximeGagnebin
MaximeGagnebin approved these changes Aug 13, 2021
View reviewed changes
Copy link
Contributor

@MaximeGagnebin MaximeGagnebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricott1 ricott1 requested a review from karmacoma August 25, 2021 10:54
@janhack janhack changed the title Add LIP: "Introduce auth module" Add LIP: "Introduce Auth module" Sep 1, 2021
@karmacoma karmacoma merged commit 47bc7fc into master Sep 7, 2021
@karmacoma karmacoma deleted the add-LIP_introduce_auth_module branch September 7, 2021 14:58
sergeyshemyakov pushed a commit that referenced this pull request Apr 20, 2022
@shuse2
Merge pull request #92 from LiskHQ/update-lip-PoA-specs
27f0976 
Update PoA LIP specifications
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karmacoma karmacoma karmacoma approved these changes

@shuse2 shuse2 shuse2 approved these changes

@ishantiw ishantiw ishantiw approved these changes

@IkerAlus IkerAlus IkerAlus approved these changes

@MaximeGagnebin MaximeGagnebin MaximeGagnebin approved these changes

Assignees

@ricott1 ricott1

Labels
new lip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ricott1 @karmacoma @shuse2 @ishantiw @IkerAlus @MaximeGagnebin