docker-compose command compatible with default Ubuntu 18.04 LTS repo #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchavant
approved these changes
Feb 19, 2020
|
We can consider this PR for the next patch release when we need to support Ubuntu 20.04. |
shuse2
approved these changes
Dec 3, 2020
|
Merging this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in LiskHQ/lisk-docs#441 the
Makefile coldstartuses a docker-compose parameter available in since version1.20.0. Unfortunately Ubuntu 18.04 LTS repo provides the1.17.0version. For the sake of convenience I propose to use the parameter available in older version.The behaviour does not change.