Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SMT prefix for branch and leaf to avoid collision #119

Merged
merged 4 commits into from Jul 24, 2023
Merged

Change SMT prefix for branch and leaf to avoid collision #119

merged 4 commits into from Jul 24, 2023

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Jul 3, 2023 •
edited

What was the problem?

This PR resolves #117 and #120.

How was it solved?

  • Prefixes for branch and leaf were changed to be globally unique.
  • calculate_root function was fixed to check that all sibling hashes were used.

How was it tested?

  • New unit tests were added.
  • All previous unit tests passed.

@matjazv matjazv self-assigned this Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Commit SHA:a69d8b8eef48a709d1df147e0bdea7469954b9d6
No changes to code coverage between the base branch and the head branch

hrmhatef
hrmhatef approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ricott1 ricott1 mentioned this pull request Jul 3, 2023
Closed
@github-actions
Copy link

Commit SHA:8cafa89ced4994a0ccf4df744d62e6e63be56c84

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 117-smt-prefix
Status File % Stmts % Branch % Funcs % Lines
🔴 total 85.8 (-0.31) 66.91 (-0.75) 94.03 (0) 85.71 (-0.32)
🔴 state_db.js 88.88 (-0.74) 68.75 (-1.56) 98.46 (0) 88.88 (-0.74)

@github-actions
Copy link

Commit SHA:8cafa89ced4994a0ccf4df744d62e6e63be56c84
Current PR reduces the test coverage percentage by 0.2 for some tests

@github-actions
Copy link

Commit SHA:a496ab4bd603d4589b0b192375ee8f082fbc5959
No changes to code coverage between the base branch and the head branch

@shuse2 shuse2 merged commit 0969ef5 into main Jul 24, 2023
8 checks passed
@shuse2 shuse2 deleted the 117-smt-prefix branch July 24, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuse2 shuse2 shuse2 approved these changes

@ricott1 ricott1 ricott1 approved these changes

@hrmhatef hrmhatef hrmhatef approved these changes

Assignees

@matjazv matjazv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change SMT prefix for leaf to avoid collision
4 participants
@matjazv @shuse2 @ricott1 @hrmhatef