Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomNode address should provide validation errors #1159

Closed
faival opened this issue Aug 13, 2018 · 1 comment
Closed

CustomNode address should provide validation errors #1159

faival opened this issue Aug 13, 2018 · 1 comment
Assignees
@faival
Labels
type: bug
Projects
Version 1.2.0

Comments

@faival
Copy link
Contributor

faival commented Aug 13, 2018

Expected behaviour

  • validation should account for malformed urls
  • when a valid address is used, peer actions should not post process address url.
  • should be possible to login with urls such: https://94.237.41.191, 94.237.41.191:7000

Actual behaviour

  • not possible to login with https://94.237.41.191, no validation errors are shown for e.g. space chars in url.

Steps to reproduce
@faival faival self-assigned this Aug 13, 2018
@faival faival added this to New Issues in Version 1.2.0 via automation Aug 13, 2018
@faival faival mentioned this issue Aug 14, 2018
Merged
faival added a commit that referenced this issue Aug 20, 2018
@faival
Merge pull request #1169 from LiskHQ/1159-customnode-address-validation
5d1784f 
Add customnode address validation - Closes #1159
@faival faival closed this as completed Aug 20, 2018
Version 1.2.0 automation moved this from New Issues to Closed Issues Aug 20, 2018
@Efefefef
Copy link
Contributor

Efefefef commented Aug 22, 2018 •
edited

localhost:4000 and 94.237.41.191:7000 are considered as invaild url, but should be valid
had no chance to test it on jenkins build

@Efefefef Efefefef reopened this Aug 22, 2018
Version 1.2.0 automation moved this from Closed Issues to New Issues Aug 22, 2018
@faival faival mentioned this issue Aug 23, 2018
Merged
@slaweet slaweet moved this from New Issues to Closed Issues in Version 1.2.0 Aug 24, 2018
@faival faival added type: bug and removed chore labels Aug 24, 2018
faival added a commit that referenced this issue Aug 24, 2018
@faival
Merge pull request #1204 from LiskHQ/1159-customnode-address-validation
e7fe7dd 
Add protocol if needed before Lisk client init - Closes #1159
@faival faival closed this as completed Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faival faival

Labels
type: bug
Projects
No open projects
Version 1.2.0
  
Closed Issues
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faival @Efefefef