Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hardware wallet #4790

Closed
15 tasks
Tracked by #4041
soroushm opened this issue Feb 6, 2023 · 0 comments
Closed
15 tasks
Tracked by #4041

Refactor hardware wallet #4790

soroushm opened this issue Feb 6, 2023 · 0 comments

Comments

@soroushm
Copy link
Contributor

soroushm commented Feb 6, 2023

Description

After gather all HW function to the HW manager and Client and move the functionality of the HW utility must be remove from the source code. Overview.

Acceptance Criteria

  • Ledger / Server - Set up folder structure & delete old IPC logic (Trezor, Ledger, utils)
  • Ledger / Server - Setup IPC main channel to talk to liskApp
  • Ledger / Server - Setup IPC listen for ledger device events
  • Ledger / Server - getSignedTransaction(devicePath, accountIndex, unsignedMessage)
  • Ledger / Server - getIsAppOpen(devicePath, accountIndex)
  • Ledger / Server - getSignedMessage(devicePath, accountIndex, unsignedMessage)
  • Ledger / Server - getPubKey(devicePath, accountIndex)
  • Ledger / Server - Implement queuing system to talk to the ledger
  • Ledger / Server - Preserve connected ledger state on page reload and on electron start
  • Ledger / Client - New Redux state: hwDevice: { currentDevice, connectedDevices }
  • Ledger / Client - Toast device notification (selectDeviceModal link if +1 devices)
  • Ledger / Client - Update Redux state: account: { ..., hwAccounts } - Part 1 (single account)
  • Ledger / Client - Switch device from topbar HW tooltip
  • Ledger / Client - Sign transaction
  • Show/Hide hardware wallet icon in top bar, hide when no device are connected
@oskarleonard oskarleonard changed the title Remove old/unused HW code Refactor HW code Mar 9, 2023
@oskarleonard oskarleonard changed the title Refactor HW code Refactor hardware wallet Mar 9, 2023
@sridharmeganathan sridharmeganathan added this to the Sprint 95 milestone Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants