Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject signing messages larger than HW device size limit #5218

Closed
ManuGowda opened this issue Aug 2, 2023 · 0 comments · Fixed by #5288
Closed

Reject signing messages larger than HW device size limit #5218

ManuGowda opened this issue Aug 2, 2023 · 0 comments · Fixed by #5288
Assignees
@oskarleonard
Labels
domain: hardware-wallet
Milestone
Sprint 107

Comments

@ManuGowda
Copy link
Contributor

Description

Hardware wallet devices have limitation on memory, each device can have a memory limit from 8k to 16k depending on the supported Ledger device (Nano S or X).

Acceptance Criteria

  • Verify message size before sending the sign request to hardware wallet
  • Reject if the message is larger than device supported memory limit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarleonard oskarleonard

Labels
domain: hardware-wallet
Projects
No open projects
Lisk Desktop Version 3.0.0
Status: Done
Milestone
Sprint 107
Development

Successfully merging a pull request may close this issue.

Reject signing message larger than hw device size limit LiskHQ/lisk-desktop
3 participants
@ManuGowda @oskarleonard @sridharmeganathan