-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject signing message larger than hw device size limit #5288
Merged
ManuGowda
merged 16 commits into
release/3.0.0
from
5218-reject-signing-message-larger-than-hw-device-size-limit
Sep 6, 2023
Merged
Reject signing message larger than hw device size limit #5288
ManuGowda
merged 16 commits into
release/3.0.0
from
5218-reject-signing-message-larger-than-hw-device-size-limit
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than-hw-device-size-limit
…than-hw-device-size-limit
ManuGowda
requested review from
ikem-legend and
ManuGowda
and removed request for
ManuGowda and
ikem-legend
September 4, 2023 10:17
ManuGowda
reviewed
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the error handling is only done for sign message? we also need to handle this for
- Sign transaction using wallet connect? when an external application tries to sign a transaction/message then we will have memory issue
- Transaction signing also needs to handle this error, i.e transaction signature collector i guess?
libs/hardwareWallet/ledger/ledgerLiskAppIPCChannel/serverLedgerHWCommunication/index.js
Outdated
Show resolved
Hide resolved
…than-hw-device-size-limit
ManuGowda
approved these changes
Sep 5, 2023
ManuGowda
deleted the
5218-reject-signing-message-larger-than-hw-device-size-limit
branch
September 6, 2023 07:49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5218
How was it solved?
Added error state when signing a message with hw wallet (to large message, disconnect hw, etc..)
How was it tested?
git pull
,yarn build
,yarn dev
,LISK_DESKTOP_URL="http://localhost:8080" DEBUG=true yarn run start
Sign wallet connect transaction on ledger device
Connect HW and open Lisk App
Initiate a sign_transaction from wallet connect
Continue the action in lisk desktop
Expected: Should be able to send the transaction