Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction signing regression #5340

Closed
Lemii opened this issue Sep 27, 2023 · 4 comments
Closed

Transaction signing regression #5340

Lemii opened this issue Sep 27, 2023 · 4 comments
Assignees
Milestone

Comments

@Lemii
Copy link

Lemii commented Sep 27, 2023

Expected behavior

Being given the ability to immediately sign a transaction with a second multisig passphrase, just like in the current version (v2.3.0).

Actual behavior

A window is shown to download the transaction, without an option to sign it with another passphrase instead.

Steps to reproduce

  1. Create a transaction
  2. Sign it with your password

Which version(s) does this affect? (Environment, OS, etc...)

Version 3.0.0-rc.1

@ManuGowda
Copy link
Contributor

@Lemii we removed the overall ability to have second passphrase as it was a legacy feature.. with new account management you can add as many accounts in account management as it involves encryption etc..

  • Add both accounts
  • Initiate from account 1, download
  • Switch to account2 and sign and broadcast

This should help?

@Lemii
Copy link
Author

Lemii commented Sep 27, 2023

@Lemii we removed the overall ability to have second passphrase as it was a legacy feature.. with new account management you can add as many accounts in account management as it involves encryption etc..

  • Add both accounts
  • Initiate from account 1, download
  • Switch to account2 and sign and broadcast

This should help?

I'm familiar with the workflow of signing a multisig transaction with multiple accounts using the download function, however it is much less user-friendly than being able to sign it immediately.

Even though it is considered a 'legacy feature' now, please bare in mind that there are a great number of users coming from the old version that are using a multisig account. It might be worth reconsidering reverting the removal of this feature.

@lisknonanika
Copy link

Can you have the following flow only if the user required to sign is added in the wallet?
image

@oskarleonard
Copy link
Contributor

oskarleonard commented Oct 4, 2023

Continuous flow for signing a multi-signature transaction

When this state is true:

  1. Wallet: [MultiSigAccount1, MultiSigAccount2]
  2. MultiSigAccount1 requires signature from MultiSigAccount2

And a user tries to sign a transaction from MultiSigAccount1 there should be a continuous flow to signing with MultiSigAccount2. Refer to this design for the flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants