Add hw wallet unit tests - Closes #1428 #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osvaldovega
reviewed
Jan 23, 2019
| <div className={styles.edit} onClick={(e) => { | ||
| <div | ||
| className={styles.edit} | ||
| onClick={/* istanbul ignore next */(e) => { |
There was a problem hiding this comment.
@michaeltomasik do you think you could put the message outside the code, I mean like
onClick={(e) => { /* istanbul ignore next */
Maybe that works too
There was a problem hiding this comment.
I tried and it needs to be there so it does not lower test coverage
| e.stopPropagation(); | ||
| }}> | ||
| <ToolBoxInput | ||
| placeholder={'Title'} | ||
| onChange={value => changeInput(value, account.address)} | ||
| theme={styles} | ||
| onKeyDown={ (event) => { if (event.keyCode === keyCodes.enter) saveAccountNames(); }} | ||
| onKeyDown={/* istanbul ignore next */(event) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
-- #1428
How have I implemented/fixed it?
How has this been tested?
Review checklist