Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement XS breakpoint of transaction component - Close #80 #160

Merged
merged 5 commits into from
Jan 5, 2018

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Jan 4, 2018

What was the problem?

XS breakpoint needed to be implemented

How can I test it?

In order to log in on mobile (with custom node) it's probably the best to just hardcode passphrase, address and network into your state in the login component, so everything is prefilled (it's impossible to fill out the network form on mobile anyway bc the forms conflict)
and make sure the login button is not disabled.

screen shot 2018-01-04 at 16 33 28

Review checklist

@ginacontrino ginacontrino self-assigned this Jan 4, 2018
@ginacontrino ginacontrino added this to Previous Issues in Sprint Board 02-01-18 via automation Jan 4, 2018
@slaweet slaweet moved this from Previous Issues to Pull Requests in Sprint Board 02-01-18 Jan 4, 2018
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gina

@ginacontrino ginacontrino merged commit 98a596b into rebranding Jan 5, 2018
Sprint Board 02-01-18 automation moved this from Pull Requests to Merged Pull Requests Jan 5, 2018
@ginacontrino ginacontrino deleted the 80-transaction-xs-breakpoint branch January 5, 2018 17:06
@slaweet slaweet changed the title Implement XS breakpoint of transaction component Implement XS breakpoint of transaction component - Close #80 Jan 5, 2018
@ginacontrino ginacontrino added this to Issues in Version 0.1.0 via automation Feb 20, 2018
@slaweet slaweet moved this from Issues to Merged Pull Requests in Version 0.1.0 Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint Board 02-01-18
  
Merged Pull Requests
Version 0.1.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants