New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Initialize account banner on dashboard - Closes #1660 #1662
Conversation
As discussed, some changes to the specification:
This might require some e2e test to be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, Massao 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks Massao. Everything works
Regarding tests please check comments and tell me if you need further clarification or help
What issue have I solved?
#1660
How have I implemented/fixed it?
Created new Banner component that have
title. children and footer
props, title being anString
, and children and footer being nodes.Added the same conditions that we have on the wallet, for showing or not the banner for initializing the account.
The background and button are different from the design, to be more consistent with the layout.
How has this been tested?
The banner should not appear if the user is not logged in any account.
Create a new account, and transfer some LSK to it, or login into an account that has LSK and didn't activate the account yet, and check if the banner shows up on the
/dashboard
, after activating the account, the banner shouldn't appear again.Review checklist