Make top bar fixed to the top - Closes #1727 #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massao
reviewed
Feb 4, 2019
massao
previously approved these changes
Feb 4, 2019
|
@osvaldovega Pls resolve merge conflict |
|
merge conflicts fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
-- #1727
How have I implemented/fixed it?
Update the css file of the topBar to make the bar be always in the top even if the user scroll down.
Then in the other hand I update the logout function to do not show the dialog message any more and just make the user to be in the logout screen.
How has this been tested?
login into the app.
do click in the Show More button of the Latest Activities or New Feeds and then scroll down.
The TopBar menu should be fixed always in the top.
Then logout the app.
There is no more dialog after logout and the user should be logged out
Review checklist