Replace old wallet with new wallet - Closes #1705 #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Efefefef "Latest activity" widget on Dashboard will be updated in a few sprints when we do the new UX of Dashboard. |
Efefefef
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
#1705
How have I implemented/fixed it?
Deleted
walletTransactionsfolder, which had the previous wallet page, didn't delete the transactions file, since the old ones are still being used on some parts of the application.Updated initial transactions load to load 30 transactions, also show more loads 30 more each time.
Updated
/walletto point to the new wallet, with new header and transaction table.Adjusted e2e tests where needed, due to the changes on behavior.
How has this been tested?
On
/walletit should have the new header and transactions table with load more button, clicking on a transaction should take the user to/explorer/transactionsinstead of how it was before.On
/dashboardclicking on a transaction should also take the user to the/explorer/transactions.The
/explorer/account, should keep the old table and the infinite scrolling, to load more.Review checklist