Implement send view transfer view - closes #1711 #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2019 00:33
massao
suggested changes
Mar 4, 2019
|
@RenatoMassao I just update the files based on the changes requested by you, I just checked that unit test and code work properly so right now everything is ok. |
massao
approved these changes
Mar 5, 2019
|
Yes yesterday they gave me the correct test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
-- #1711
How have I implemented/fixed it?
This PR includes the form where the user add the address or bookmark account name, the amount and the reference is the form validates that inputs to see if the data is correct, if everything is correct the button is enable to continue
How has this been tested?
once that the send form is loaded, you can check that the button is disabled so the user it is not able to continue, if there is no bookmarks account the user needs to enter a valid address in case that write something invalid a error message and icon will be display.
In case that there are bookmark accounts that user can type some words or digits of the address and a list will show up where the user can see what bookmarks are available, in case that something is wrong is error message and icon will be display if everything is ok the icon will be green.
The same logic apply for the amount input and reference that it is optional.
After everything be properly fill and correct the button will be enable.
NOTE: For test this you need to change the browser URL from http://localhost:8080/#/wallet/send to http://localhost:8080/#/wallet/sendV2
Review checklist