Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate transaction detail page to final UI - Closes #1841 #1883

Merged
merged 5 commits into from Apr 4, 2019

Conversation

massao
Copy link
Contributor

@massao massao commented Apr 3, 2019

What issue have I solved?

#1841

How have I implemented/fixed it?

Migrated transaction detail page to final UI, and updated unit tests where needed.

How has this been tested?

Open any transaction and the design should be the final UI.
transfer, 2nd passphrase registration, delegate registration and voting transactions should have the new design.

Review checklist

@massao massao self-assigned this Apr 3, 2019
@massao massao changed the base branch from 1839-migrate-wallet-tab-to-final-ui to 1.15.0 April 3, 2019 15:58
@massao massao changed the base branch from 1.15.0 to development April 4, 2019 10:51
@massao massao changed the base branch from development to 1.15.0 April 4, 2019 10:51
Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work man.... 🏋🏻‍♂️

@massao massao merged commit 1a80bf9 into 1.15.0 Apr 4, 2019
@massao massao deleted the 1841-migrate-tx-detail-page-to-final-UI branch April 4, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants