Transaction list filtering not working properly - Closes #1912 #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious request finished
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
#1912
How have I implemented/fixed it?
The problem here was with the
transctionUpdatedaction, since the filter was being changed after the request was sent, it was fetching the wrong data and dispatching to the store, so it got the filtered and the updated data mixed.I added a condition to only dispatch to the store if the filter didn't change between the action being called and the data being fetched.
How has this been tested?
Tested with cypress locally a lot of times, and couldn't get the error to happen again, event when making the network slower.
Review checklist