Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction filters - Closes #32 #211

Merged
merged 9 commits into from
Jan 18, 2018
Merged

Conversation

ginacontrino
Copy link
Contributor

@ginacontrino ginacontrino commented Jan 16, 2018

What was the problem?

The transaction filters were not working

How did I fix it?

  • Implemented All, Incoming and Outgoing
  • Also fixes the incorrect amount display (incorrect styles and +,-)

How to test it?

Go through and filter!

Review checklist

@ginacontrino ginacontrino self-assigned this Jan 16, 2018
@ginacontrino ginacontrino added this to New Issues in Sprint Board 15-01-18 via automation Jan 16, 2018
@slaweet slaweet moved this from New Issues to Pull Requests in Sprint Board 15-01-18 Jan 16, 2018
Gina Contrino and others added 3 commits January 18, 2018 10:51
.. to make switching transactions filter more responsive on slow
network connection
... to make it consistent with 25 used in  transactions middleware
and avoid e2e test failing randomly
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Gina

@ginacontrino ginacontrino merged commit 230be22 into 0.1.0 Jan 18, 2018
Sprint Board 15-01-18 automation moved this from Pull Requests to Merged Pull Requests Jan 18, 2018
@ginacontrino ginacontrino deleted the 32-transaction-filters branch January 18, 2018 14:55
@ginacontrino ginacontrino added this to Issues in Version 0.1.0 via automation Feb 20, 2018
@slaweet slaweet moved this from Issues to Merged Pull Requests in Version 0.1.0 Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint Board 15-01-18
  
Merged Pull Requests
Version 0.1.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

2 participants