Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recent transactions on dashboard - Closes #2253 #2381

Merged
merged 2 commits into from Aug 22, 2019

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Aug 21, 2019

What issue have I solved?

#2253

How have I implemented/fixed it?

  • Fix the logic for displayed address to account.address === tx.recipientId ? tx.senderId : tx.recipientId
  • Fix styles of "amount" to
    1. not have a fixed height, so even if it's two lines it's all in the green box
    2. show only at most 2 decimal points on the dashboard as there is not much more space anyway. There was a suggestion to use the same logic as in Lisk Mobile https://github.com/LiskHQ/lisk-mobile/blob/development/src/components/shared/formattedNumber/index.js but that one doesn't handle localization so I didn't use it.

How has this been tested?

  • Send some transactions with long numbers, e.g. 0.92046708 LSK
  • Check how are they displayed on the dashboard

Review checklist

@slaweet slaweet self-assigned this Aug 21, 2019
Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slaweet I check the code and test it and looks good everything works as should be, but there is one minor details that is in the Recent Transaction component the last row has a underline and it shouldnt I know that is part of your other ticket but dont know if you already rebase or not.

Just in case
Screen Shot 2019-08-21 at 14 27 19

@slaweet
Copy link
Contributor Author

slaweet commented Aug 21, 2019

@slaweet I check the code and test it and looks good everything works as should be, but there is one minor details that is in the Recent Transaction component the last row has a underline and it shouldnt I know that is part of your other ticket but dont know if you already rebase or not.

This was changed only after 1.20.0. You can check the base branches:
https://jenkins.lisk.io/test/lisk-hub/development/#/dashboard
https://jenkins.lisk.io/test/lisk-hub/release-1.20.0/#/dashboard

Copy link
Contributor

@osvaldovega osvaldovega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you are right my fault all good then

Copy link
Contributor

@Efefefef Efefefef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@Efefefef Efefefef added the ready label Aug 22, 2019
@slaweet slaweet merged commit a7467c9 into release-1.20.0 Aug 22, 2019
@slaweet slaweet deleted the 2253-fix-recent-transactions-on-dashboard branch August 22, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants