Fix BTC address calculation - Closes #3772 #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuGowda
reviewed
Sep 8, 2021
reyraa
force-pushed
the
3772-refactor-account-updated
branch
from
21a718d
to
b949608
Compare
ManuGowda
reviewed
Sep 9, 2021
There was a problem hiding this comment.
@reyraa the change itself LGTM, although I must say I do not have the full context of codebase, but the changes itself looks good.
I see you have added in PR unit tested, I do not see any unit test, could you please add the tests?
isalga
approved these changes
Sep 9, 2021
ManuGowda
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #3772
How was it solved?
Since we added an API response normalizer to the BTC API, we don't need to distinguish the responses in the utility level.
How was it tested?
unit tests