Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leftover height issues - Closes #367 #393

Merged
merged 8 commits into from
Feb 16, 2018
Merged

Fix leftover height issues - Closes #367 #393

merged 8 commits into from
Feb 16, 2018

Conversation

yasharAyari
Copy link
Contributor

What was the problem?

There were some leftover height issues from #298, for example the side menu can still be improved, and the height in the registration process was too big

Review checklist

  • The PR solves Fix leftover height issues #367
  • All new code is covered with unit tests
  • All new features are covered with e2e tests
  • All new code follows best practices

@yasharAyari yasharAyari self-assigned this Feb 16, 2018
@yasharAyari yasharAyari added this to Previous Issues in Sprint Board 12-02-18 via automation Feb 16, 2018
@yasharAyari yasharAyari moved this from Previous Issues to Pull Requests in Sprint Board 12-02-18 Feb 16, 2018
slaweet
slaweet approved these changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Yashar

@yasharAyari yasharAyari merged commit a182a9b into 0.1.0 Feb 16, 2018
Sprint Board 12-02-18 automation moved this from Pull Requests to Merged Pull Requests Feb 16, 2018
@yasharAyari yasharAyari deleted the 367-fix-leftover-height-issues branch February 16, 2018 16:19
@Matthelonianxl Matthelonianxl mentioned this pull request Mar 13, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 18, 2021
Open
This was referenced May 13, 2022
Open
Open
@Matthelonianxl Matthelonianxl mentioned this pull request Nov 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@reyraa reyraa Awaiting requested review from reyraa

Assignees

@yasharAyari yasharAyari

Labels
None yet
Projects
No open projects
Sprint Board 12-02-18
  
Merged Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yasharAyari @slaweet