Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the blockchain application removal flow- Closes #4375 #4393

Conversation

eniolam1000752
Copy link
Contributor

@eniolam1000752 eniolam1000752 commented Jul 11, 2022

What was the problem?

This PR resolves #4375

How was it solved?

  • Implement the RemoveApplicationDetails component
  • Implement the RemoveApplicationSuccess component
  • integrate RemoveApplicationDetails, RemoveApplicationSuccess and useApplicationManagement hook to create the Whole flow
  • implement unit test
  • implement e2e tests

NOTE: Some e2e tests could not be achieved in this pr because presently we can't set the current application on the app on runtime. but after #4359 is done then these tests can be achieved

How was it tested?

jest
e2e

@eniolam1000752 eniolam1000752 self-assigned this Jul 11, 2022
@eniolam1000752 eniolam1000752 changed the title implement blockchain application removal - Closes #4375 Implement the blockchain application removal flow- Closes #4375 Jul 11, 2022
@eniolam1000752 eniolam1000752 marked this pull request as ready for review July 12, 2022 15:48
@ManuGowda ManuGowda removed the request for review from isalga July 13, 2022 12:01
soroushm
soroushm previously approved these changes Jul 13, 2022
@eniolam1000752 eniolam1000752 merged commit d7a16ab into feature/blockchain-application Jul 14, 2022
@ManuGowda ManuGowda deleted the 4375-implement-blockchain-application-removal branch July 14, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants