-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the blockchain application removal flow- Closes #4375 #4393
Merged
eniolam1000752
merged 10 commits into
feature/blockchain-application
from
4375-implement-blockchain-application-removal
Jul 14, 2022
Merged
Implement the blockchain application removal flow- Closes #4375 #4393
eniolam1000752
merged 10 commits into
feature/blockchain-application
from
4375-implement-blockchain-application-removal
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikem-legend
reviewed
Jul 13, 2022
ikem-legend
reviewed
Jul 13, 2022
tests/cypress/features/blockchainManagement/blockchainManagement.js
Outdated
Show resolved
Hide resolved
soroushm
previously approved these changes
Jul 13, 2022
ikem-legend
reviewed
Jul 13, 2022
...blockchainApplication/manage/components/RemoveApplicationDetails/RemoveApplicationDetails.js
Outdated
Show resolved
Hide resolved
ikem-legend
reviewed
Jul 13, 2022
...blockchainApplication/manage/components/RemoveApplicationDetails/RemoveApplicationDetails.js
Outdated
Show resolved
Hide resolved
ikem-legend
approved these changes
Jul 13, 2022
soroushm
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #4375
How was it solved?
RemoveApplicationDetails
componentRemoveApplicationSuccess
componentRemoveApplicationDetails
,RemoveApplicationSuccess
anduseApplicationManagement
hook to create the Whole flowNOTE: Some e2e tests could not be achieved in this pr because presently we can't set the current application on the app on runtime. but after #4359 is done then these tests can be achieved
How was it tested?
jest
e2e