Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage - Closes #471 #503

Merged
merged 4 commits into from Mar 2, 2018
Merged

Improve test coverage - Closes #471 #503

merged 4 commits into from Mar 2, 2018

Conversation

yasharAyari
Copy link
Contributor

What was the problem?

We have some files in the list of coverage exclude files and they needed to be reduce as much as possible

Review checklist

@yasharAyari yasharAyari self-assigned this Mar 2, 2018
@yasharAyari yasharAyari added this to New Issues in Version 0.2.0 via automation Mar 2, 2018
@yasharAyari yasharAyari requested a review from slaweet March 2, 2018 09:47
@yasharAyari yasharAyari added this to Previous Issues in Sprint Board 26-02-18 via automation Mar 2, 2018
@yasharAyari yasharAyari changed the base branch from development to 0.2.0 March 2, 2018 09:47
@yasharAyari yasharAyari requested a review from reyraa March 2, 2018 11:15
@slaweet slaweet moved this from Previous Issues to Pull Request in Sprint Board 26-02-18 Mar 2, 2018
@slaweet slaweet moved this from New Issues to Pull Requests in Version 0.2.0 Mar 2, 2018
@slaweet slaweet changed the base branch from 0.2.0 to 0.3.0 March 2, 2018 12:57
@slaweet slaweet added this to Issues in Version 0.3.0 via automation Mar 2, 2018
@slaweet slaweet removed this from Pull Requests in Version 0.2.0 Mar 2, 2018
@slaweet slaweet moved this from Issues to Pull Requests in Version 0.3.0 Mar 2, 2018
slaweet
slaweet approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@slaweet slaweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Yashar

@yasharAyari yasharAyari merged commit f92f0af into 0.3.0 Mar 2, 2018
Sprint Board 26-02-18 automation moved this from Pull Request to Merged Pull Requests Mar 2, 2018
Version 0.3.0 automation moved this from Pull Requests to Merged Pull Requests Mar 2, 2018
@yasharAyari yasharAyari deleted the 471-improve-test-coverage branch March 2, 2018 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaweet slaweet slaweet approved these changes

@reyraa reyraa Awaiting requested review from reyraa

Assignees

@yasharAyari yasharAyari

Labels
None yet
Projects
No open projects
Sprint Board 26-02-18
  
Merged Pull Requests
Version 0.3.0
  
Merged Pull Requests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yasharAyari @slaweet