Handle add/switch account flow on WC message signing method #5282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManuGowda
previously approved these changes
Sep 1, 2023
oskarleonard
reviewed
Sep 1, 2023
src/modules/blockchainApplication/connection/components/RequestSummary/index.js
Show resolved
Hide resolved
oskarleonard
reviewed
Sep 1, 2023
| @@ -119,7 +119,7 @@ export const useSession = () => { | |||
| ); | |||
|
|
|||
| useEffect(() => { | |||
| if (signClient?.session && !hasLoaded) { | |||
| if (signClient?.session && !hasLoaded && isEnabled) { | |||
There was a problem hiding this comment.
Shouldnt we loadSessions if isEnabled become enabled? Dont we need it in the dep array in that case?
oskarleonard
previously approved these changes
Sep 1, 2023
eniolam1000752
dismissed stale reviews from oskarleonard and ManuGowda
via
8876a1a
ManuGowda
approved these changes
Sep 1, 2023
ManuGowda
deleted the
5278-implement-wc-message-signing-account-journey
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5278
How was it solved?
RequstSummarycomponent to the RequestSignMessageDialog multi stepRequestSummaryto work properly in message modeHow was it tested?