E2E pipeline, common hooks, test for request token #5318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarleonard
requested review from
ikem-legend,
ManuGowda and
eniolam1000752
ManuGowda
reviewed
Sep 19, 2023
ikem-legend
previously approved these changes
Sep 19, 2023
eniolam1000752
suggested changes
Sep 19, 2023
| Feature: Request Token | ||
| Background: Add an account and navigate to wallet | ||
| Given I add an account with passphrase "peanut hundred pen hawk invite exclude brain chunk gadget wait wrong ready" password "Password1$" name 'test_acc' | ||
| Then I go to page "wallet" |
There was a problem hiding this comment.
this should be
Suggested change
| Then I go to page "wallet" | |
| And I go to page "wallet" |
since its an action not an assertion
| And button with text 'Copy link' should be disabled | ||
| Given I type "10" in "amount" | ||
| Then button with text "Copy link" should be enabled | ||
| And I click on a button with text "Copy link" |
There was a problem hiding this comment.
This should be Given not And since it comes after an assertive phrase
Suggested change
| And I click on a button with text "Copy link" | |
| Given I click on a button with text "Copy link" |
ManuGowda
reviewed
Sep 19, 2023
oskarleonard
requested review from
ManuGowda,
ikem-legend and
eniolam1000752
eniolam1000752
previously approved these changes
Sep 20, 2023
ManuGowda
reviewed
Sep 20, 2023
|
the CI is red |
ManuGowda
approved these changes
Sep 20, 2023
ikem-legend
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5080
How was it solved?
setWorldConstructorHow was it tested?
Please be aware of that the test can sometimes fail if our E2E service network responds slowly. In that case, just rerun the test before starting to investigate why tests are failing.
Pass scenario
yarn devPW_BASE_URL=http://localhost:8080/# yarn run cucumber:playwright:openFail scenario
RequestToken.featureAnd "lisk_mainchain"...toAnd "none_existing_text"...PW_BASE_URL=http://localhost:8080/# yarn run cucumber:playwright:opene2e/assets/screenshotswhere you can see a screenshoot of the failed test.