Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return transactionJSON to walletconnect #5460

Merged

Conversation

oskarleonard
Copy link
Contributor

What was the problem?

This PR resolves #5449

How was it solved?

Return transaction instead of signature for wallet connect requests.

How was it tested?

  1. Sign with multisig through wallet connect
  2. Sign with regular account through wallet connect
  3. Expected: The copy to clipboard button should contain data (The transaction)

@ManuGowda ManuGowda merged commit 2ea25fa into release/3.0.0 Nov 17, 2023
6 checks passed
@ManuGowda ManuGowda deleted the 5449-unable-to-sign-multisig-with-wallet-connect branch November 17, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants