Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split passphrase/create css into smaller files - subTask #513 #655

Merged
merged 5 commits into from
Apr 3, 2018

Conversation

reyraa
Copy link
Contributor

@reyraa reyraa commented Apr 3, 2018

What was the problem?

The component and hence the css rules in passphrase/create were large and hard to maintain. this ticket aims to split them into smaller/single purpose files.

Review checklist

@reyraa reyraa requested a review from faival April 3, 2018 05:48
@reyraa reyraa self-assigned this Apr 3, 2018
@reyraa reyraa added this to Issues in Version 0.4.0 via automation Apr 3, 2018
@reyraa reyraa added this to Previous Issues in Sprint Board 26-03-18 via automation Apr 3, 2018
@reyraa reyraa changed the base branch from development to 0.4.0 April 3, 2018 05:48
@slaweet slaweet moved this from Previous Issues to Pull Requests in Sprint Board 26-03-18 Apr 3, 2018
faival
faival previously approved these changes Apr 3, 2018
Copy link
Contributor

@ginacontrino ginacontrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job 🎉

@reyraa reyraa merged commit 992e1b8 into 0.4.0 Apr 3, 2018
Version 0.4.0 automation moved this from Issues to Merged Pull Requests Apr 3, 2018
Sprint Board 26-03-18 automation moved this from Pull Requests to Merged Pull Requests Apr 3, 2018
@reyraa reyraa deleted the 513-split-css-passphrase-create branch April 3, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Sprint Board 26-03-18
  
Merged Pull Requests
Version 0.4.0
  
Merged Pull Requests
Development

Successfully merging this pull request may close these issues.

None yet

4 participants