Random failing e2etests due to reseting transaction filter - Closes #875 #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th wrong props.address
faival
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
there is logic to reset a filter after component will unmount,
when reseting the filter a request is made,
this request happens when e.g. changing the address searched, therefore in this scenario what happens is:
search url changes A-> B
componentWillUnmount triggers request to load transacions of A
component constructor triggers load transactions request with B
load transactions B resolves and updates store
load transactions A resolves and updates store clearing results for B
How did I fix it?
How to test it?
Review checklist