Change 101 delegate to status active - Closes #948 #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faival
reviewed
Jun 26, 2018
| @@ -11,7 +11,7 @@ class DelegateStatistics extends React.Component { | |||
|
|
|||
| let status = ''; | |||
| if (delegate && delegate.rank) { | |||
| status = delegate.rank < 101 ? this.props.t('Active') : this.props.t('Standby'); | |||
| status = delegate.rank <= 101 ? this.props.t('Active') : this.props.t('Standby'); | |||
There was a problem hiding this comment.
not belonging to the change itself but will be ideal to use constants/voting.maxCountOfVotes
michaeltomasik
force-pushed
the
948-rank-101-should-be-active
branch
from
0131557
to
cc20dc0
Compare
...until testnet and mainnet are aligned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Delegate 101 didn't have active status
How did I fix it?
Added correct condition
How to test it?
Go to delegate list and check 101 delegate
Review checklist