Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

1180 fix broken links in guides in sdk docs v5.1.4 #1190

Merged
merged 3 commits into from
Oct 4, 2021
Merged

1180 fix broken links in guides in sdk docs v5.1.4 #1190

merged 3 commits into from
Oct 4, 2021

Conversation

chris529
Copy link
Contributor

@chris529 chris529 commented Oct 1, 2021

Closes #1180

@chris529 chris529 added type: bug Errors in the documentation component: sdk Lisk SDK labels Oct 1, 2021
@chris529 chris529 added this to the Sprint 01 milestone Oct 1, 2021
@chris529 chris529 self-assigned this Oct 1, 2021
Tschakki
Tschakki suggested changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@Tschakki Tschakki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor correction, otherwise LGTM

modules/ROOT/pages/guides/app-development/module.adoc Outdated Show resolved Hide resolved
@chris529 @Tschakki
Update modules/ROOT/pages/guides/app-development/module.adoc
c729bb0 
Co-authored-by: Mona Bärenfänger <mona@lightcurve.io>
@chris529 chris529 requested a review from Tschakki October 4, 2021 07:58
Tschakki
Tschakki approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@Tschakki Tschakki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tschakki Tschakki merged commit 4f53daf into docs-sdk Oct 4, 2021
@sridharmeganathan sridharmeganathan removed this from the Sprint 01 milestone Oct 11, 2021
@shuse2 shuse2 deleted the 1180-fix-broken-links-in-guides-in-sdk-docs-v5.1.4 branch November 29, 2021 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tschakki Tschakki Tschakki approved these changes

Assignees

@chris529 chris529

Labels
component: sdk Lisk SDK type: bug Errors in the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken links in guides
3 participants
@chris529 @Tschakki @sridharmeganathan