Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lisk.io to lisk.com - Partially closes #1184 #1201

Merged
merged 2 commits into from Oct 14, 2021
Merged

Update lisk.io to lisk.com - Partially closes #1184 #1201

merged 2 commits into from Oct 14, 2021

Conversation

Tschakki
Copy link
Member

Partially closes #1184

@Tschakki Tschakki added the component: service Lisk Service label Oct 12, 2021
@Tschakki Tschakki self-assigned this Oct 12, 2021
@Tschakki Tschakki added this to Open PRs in Lisk Service documentation via automation Oct 12, 2021
@Tschakki Tschakki mentioned this pull request Oct 12, 2021
Closed
4 tasks
@Tschakki Tschakki linked an issue Oct 12, 2021 that may be closed by this pull request
Update domain lisk.io to lisk.com #1184
Closed
4 tasks
chris529
chris529 reviewed Oct 13, 2021
View reviewed changes
Copy link
Contributor

@chris529 chris529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of very minor points 👍

modules/ROOT/pages/references/configuration.adoc Outdated Show resolved Hide resolved
modules/ROOT/pages/references/rpc-api.adoc Outdated Show resolved Hide resolved
@Tschakki @chris529
Apply suggestions from code review
e83d1e8 
Co-authored-by: chris529 <christopher.braithwaite@lightcurve.io>
chris529
chris529 approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@chris529 chris529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Tschakki Tschakki merged commit e83d1e8 into docs-service Oct 14, 2021
Lisk Service documentation automation moved this from Open PRs to Merged PRs Oct 14, 2021
@shuse2 shuse2 deleted the 1184-service-lisk-com branch November 29, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris529 chris529 chris529 approved these changes

@shuse2 shuse2 Awaiting requested review from shuse2

Assignees

@Tschakki Tschakki

Labels
component: service Lisk Service
Projects
No open projects
Lisk Service documentation
Merged PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update domain lisk.io to lisk.com
2 participants
@Tschakki @chris529