Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional instructions to SDK tutorials, closes #330 #331

Merged
merged 3 commits into from Aug 14, 2019
Merged

Add additional instructions to SDK tutorials, closes #330 #331

merged 3 commits into from Aug 14, 2019

Conversation

Tschakki
Copy link
Member

@Tschakki Tschakki commented Aug 9, 2019

Closes #330

@Tschakki Tschakki self-assigned this Aug 9, 2019
@Tschakki Tschakki requested a review from 4miners August 13, 2019 15:30
RachBLondon
RachBLondon previously approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@RachBLondon RachBLondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

tutorials/cashback.md Outdated Show resolved Hide resolved
tutorials/hello-world.md Outdated Show resolved Hide resolved
tutorials/hello-world.md Outdated Show resolved Hide resolved
tutorials/hello-world.md Outdated Show resolved Hide resolved
tutorials/hello-world.md Outdated Show resolved Hide resolved
@Tschakki @RachBLondon
Apply suggestions from code review
d37da72 
Co-Authored-By: Rachel <rachblondon@gmail.com>
@Tschakki Tschakki merged commit d37da72 into dev-start-1.2 Aug 14, 2019
@Tschakki Tschakki added this to Merged PRs in Lisk Alpha SDK via automation Aug 14, 2019
@karmacoma karmacoma removed the start label Dec 17, 2019
@Tschakki Tschakki deleted the 330-add-instructions branch January 14, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RachBLondon RachBLondon RachBLondon approved these changes

@4miners 4miners Awaiting requested review from 4miners

Assignees

@Tschakki Tschakki

Labels
None yet
Projects
No open projects
Lisk Alpha SDK
  
Merged PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tschakki @RachBLondon @karmacoma