Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Clean up file structure and name in transaction module #1063

Closed
shuse2 opened this issue Jan 31, 2019 · 0 comments
Closed

Clean up file structure and name in transaction module #1063

shuse2 opened this issue Jan 31, 2019 · 0 comments
Assignees
@shuse2
Labels
*easy lisk-transactions ♻️ refactoring
Projects
Version 2.1.0

Comments

@shuse2
Copy link
Contributor

shuse2 commented Jan 31, 2019

Description

all of the main files can be on root level with consistent naming

0_transfer.ts
0_transfer_transaction.ts
...
base_transaction.ts
response.ts
errors.ts

Also, within utils, we should clarify responsibility of each file.
Maybe we can put all the deprecated functions in one file and exposed until the major version.
@shuse2 shuse2 self-assigned this Jan 31, 2019
@shuse2 shuse2 added this to To Do in Version 2.1.0 via automation Jan 31, 2019
@shuse2 shuse2 moved this from To Do to In Progress in Version 2.1.0 Feb 9, 2019
This was referenced Feb 9, 2019
Merged
Closed
Version 2.1.0 automation moved this from In Progress to Done Feb 11, 2019
shuse2 added a commit that referenced this issue Feb 11, 2019
@shuse2
Merge pull request #1087 from LiskHQ/1063-cleanup_file_structure
982a617 
Cleanup file structure and unused functions - Closes #1063 & #1046
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuse2 shuse2

Labels
*easy lisk-transactions ♻️ refactoring
Projects
No open projects
Version 2.1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shuse2