This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Cleanup file structure and unused functions - Closes #1063 & #1046 #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuaki-u
previously approved these changes
Feb 10, 2019
shuse2
changed the title
pablitovicente
previously approved these changes
Feb 11, 2019
shuse2
force-pushed
the
1063-cleanup_file_structure
branch
from
27dd86d
to
d87fe3e
Compare
shuse2
dismissed stale reviews from pablitovicente and mitsuaki-u
via
d87fe3e
shuse2
changed the base branch from
1050-combine_verify_function
to
development
SargeKhan
approved these changes
Feb 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
File structure was unclear, and the are several unused functions.
How did I fix it?
Remove
transactionsfolder and move to root level with consistent name.Remove unused functions and organize function into more distinct file
How to test it?
npm tReview checklist