Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register delegate: Erasing name input sends empty username availability request #1090

Closed
Efefefef opened this issue Jul 25, 2018 · 0 comments
Assignees

Comments

@Efefefef
Copy link
Contributor

Efefefef commented Jul 25, 2018

Steps to reproduce

  1. Register delegate
  2. Enter name
  3. Erase name

Actual result

"...checking availablility"
request with empty username ->
400 bad response
{"message":"Validation errors","errors":[{"code":"INVALID_REQUEST_PARAMETER","message":"Invalid parameter (username): Value failed JSON Schema validation","in":"query","name":"username","errors":[{"code":"MIN_LENGTH","message":"String is too short (0 chars), minimum 1","path":[]}]}]}

Expected result

No request sent for empty string

image

@Efefefef Efefefef added the bug label Jul 25, 2018
@slaweet slaweet added the *easy label Jul 26, 2018
faival added a commit that referenced this issue Aug 6, 2018
…t-empty-sends-request

Register Delegate , prevent sent request to core on empty username - Closes #1090
@faival faival closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants