New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network indicator is not shown if 'Switch Networks' is off #1251

Closed
Efefefef opened this Issue Sep 5, 2018 · 1 comment

Comments

Projects
3 participants
@Efefefef
Contributor

Efefefef commented Sep 5, 2018

Steps to reproduce

  1. Turn on 'Switch Networks' in settings
  2. Login in test or dev net
  3. Turn off 'Switch Networks'
  4. Logout

Actual result

Network indicator disappears
In a logged out state, I have an impression I am searching in mainnet

Expected result

Network indicator is not dependant on 'Switch Networks'

@slaweet slaweet added this to New Issues in Version 1.3.0 via automation Sep 5, 2018

@slaweet

This comment has been minimized.

Show comment
Hide comment
@slaweet

slaweet Sep 10, 2018

Member

I originally (#1103) thought it should work as it does, but Andrei is right that testnet/custom node should be displayed always. Only Mainnet should depend on the show-network-swicher setting.

Member

slaweet commented Sep 10, 2018

I originally (#1103) thought it should work as it does, but Andrei is right that testnet/custom node should be displayed always. Only Mainnet should depend on the show-network-swicher setting.

@slaweet slaweet closed this in e762a55 Sep 13, 2018

Version 1.3.0 automation moved this from New Issues to Closed Issues Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment