You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At this moment the hwWallet code is split in hwWallet middleware functions in utils and utils/api, in these 3 places the hwWallets are being check and based on an action this trigger an specific event, some information is being set in the localStorage and in the same time in the redux store.
So the problem at this moment is that some data could be duplicated in the project and store in localStorage and this could be not necessary.
Suggested solution
Create a generic/modular solution that helps to handle any hwWallet device detection and interaction for dont have to change or add files in the future to handle a new hardware wallet device, so the communication and interaction could be the same in the react project and then in the electron part implement the logic for the specific device.
So for the react part we can update or modify the actions, reducers, local storage and then middlewares and find the better place to handle the ipc messages and the dispatch of the actions, then check if the actual structure that we have for this can be redefine and then remove it from the local storage
The text was updated successfully, but these errors were encountered:
yasharAyari
changed the title
Refactor logic and structure for hwWallet in electron and react
Create a refactor proposal for logic and structure of hwWallet in electron and react
May 23, 2019
Description of the problem
At this moment the hwWallet code is split in hwWallet middleware functions in utils and utils/api, in these 3 places the hwWallets are being check and based on an action this trigger an specific event, some information is being set in the localStorage and in the same time in the redux store.
So the problem at this moment is that some data could be duplicated in the project and store in localStorage and this could be not necessary.
Suggested solution
Create a generic/modular solution that helps to handle any hwWallet device detection and interaction for dont have to change or add files in the future to handle a new hardware wallet device, so the communication and interaction could be the same in the react project and then in the electron part implement the logic for the specific device.
So for the react part we can update or modify the actions, reducers, local storage and then middlewares and find the better place to handle the ipc messages and the dispatch of the actions, then check if the actual structure that we have for this can be redefine and then remove it from the local storage
The text was updated successfully, but these errors were encountered: