Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forged and missed blocks numbers in delegate statistics - Closes #1034 #1039

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Fix forged and missed blocks numbers in delegate statistics - Closes #1034 #1039

merged 1 commit into from
Jul 13, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Jul 13, 2018

What was the problem?

See #1034

How did I fix it?

producedblocks changed to producedBlocks
missedblocks changed to missedBlocks
because it changed in the Lisk Core 1.0.0 API

How to test it?

Follow steps in #1034

Review checklist

@slaweet slaweet self-assigned this Jul 13, 2018
@slaweet slaweet requested a review from faival July 13, 2018 13:22
faival
faival approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@faival faival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @slaweet !

@slaweet slaweet merged commit c67b2b9 into 1.0.0 Jul 13, 2018
@slaweet slaweet deleted the 1034-fix-delegate-statistics branch July 13, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faival faival faival approved these changes

Assignees

@slaweet slaweet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slaweet @faival