Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent saved devnet account listed twice - Closes #1049 #1176

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Aug 15, 2018

What was the problem?

See #1049 .
The root cause was that when changing address -> peerAddress in saved accounts, it was not done in one place in savedAcconts middleware.

How did I fix it?

I changed address -> peerAddress in one place in savedAcconts middleware

How to test it?

Follow steps in #1049

Review checklist

Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Contributor

@Efefefef Efefefef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@slaweet slaweet merged commit aae39c7 into 1.1.0 Aug 15, 2018
@slaweet slaweet deleted the 1049-fix-duplicate-saved-account branch August 15, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants