Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create guideline template and table of contents - Closes #1229 #1230

Merged
merged 5 commits into from
Sep 3, 2018
Merged

Create guideline template and table of contents - Closes #1229 #1230

merged 5 commits into from
Sep 3, 2018

Conversation

faival
Copy link
Contributor

@faival faival commented Aug 30, 2018 •
edited
Loading

What was the problem?

How did I fix it?

  • add a template, and a basic index file to handle documentation in a centralised way.

How to test it?

Review checklist

@faival faival self-assigned this Aug 30, 2018
@faival faival changed the base branch from development to 1.3.0 August 30, 2018 08:01
michaeltomasik
michaeltomasik previously approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💯

michaeltomasik
michaeltomasik reviewed Aug 31, 2018
View reviewed changes
docs/DEVELOPMENT_GUIDE.md Outdated

This project and everyone participating in it is governed by the
[Lisk Code of Conduct](https://github.com/LiskHQ/lisk/blob/development/docs/CODE_OF_CONDUCT.md). By participating, you are
expected to uphold this code. Please report unacceptable behavior to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please report the unacceptable behaviour to

michaeltomasik
michaeltomasik previously approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@michaeltomasik michaeltomasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@faival
Copy link
Contributor Author

faival commented Aug 31, 2018

refactored contributing to move PR related to it's own guideline file

@faival faival merged commit bf493ca into 1.3.0 Sep 3, 2018
@slaweet slaweet deleted the 1229-create-guideline-template-table-of-contents branch September 12, 2018 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Efefefef Efefefef Efefefef approved these changes

@michaeltomasik michaeltomasik michaeltomasik left review comments

Assignees

@faival faival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faival @Efefefef @michaeltomasik