Implement login with more than 12 words - Closes #1748 #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Q/lisk-hub into 1748-login-with-more-than-12-words
Efefefef
suggested changes
Feb 20, 2019
Efefefef
approved these changes
Feb 20, 2019
|
Good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue have I solved?
#1748
How have I implemented/fixed it?
Implemented logic on
passphraseInputV2component to show 24 fields, when the user paste a passphrase with more than 12 words, or if the user pressesspace,taborright arrowon the 12th field.How has this been tested?
Go to
/loginand paste a passphrase with more than 12 words, or pressspace,taborright arrowon the 12th field, if wants to go back to having 12 fields, it's needed to go back to the previous page an go again to/loginReview checklist